sadpandajoe commented on code in PR #44459:
URL: https://github.com/apache/superset/pull/44459#discussion_r4139027443
##########
superset-frontend/webpack.proxy-config.js:
##########
@@ -185,7 +169,14 @@ async function processHTML(proxyResponse, response) {
response.end(toDevHTML(Buffer.concat(chunks).toString()));
}
-export default function getProxyConfig(newManifest) {
+export default function getProxyConfig(newManifest, env = {}) {
+ const parsedEnvArgs = { ...importTimeEnvVars, ...env };
+ const { supersetPort = 8088, supersetUrl = null } = parsedEnvArgs;
Review Comment:
The documented `--env=--supersetPort=...` and `--env=--supersetUrl=...`
invocations now reach this object under keys with the leading `--`, so this
destructuring falls back to `localhost:8088` instead of the requested backend.
Could we normalize those keys here or update the examples to the webpack-cli
syntax this config accepts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
