mattmc3 opened a new pull request, #44807: URL: https://github.com/apache/superset/pull/44807
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY `Table` gives virtualized tables `scroll.x = '100vw'`. `VirtualTable` passed that straight to antd, so the header table sized to the viewport while the react-window body sized to its container. Anywhere the table is narrower than the viewport, like the Drill to detail modal, the header columns come out wider than the data and drift further out of line with each column. This sets the header's `scroll.x` to the Grid's column total so both use the same widths. Fixes #43558. Related to #43383 and #43472, which handles scrollbar width and is a separate issue. This fix doesn't conflict with #43472 and works with or without it. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before (header columns all out of place): <img width="750" alt="Screenshot 2026-09-29 at 18 50 52" src="https://github.com/user-attachments/assets/e3f078d4-8983-4966-82c8-1992ff67d61d"; /> After (header columns align): <img width="750" alt="Screenshot 2026-09-29 at 18 41 12" src="https://github.com/user-attachments/assets/99117c89-a93c-4e25-bbe1-ace62e986bcd"; /> ### TESTING INSTRUCTIONS 1. Open a chart on a dashboard, right-click it and choose Drill to detail. 2. Check that each column header lines up with its data, including the last column. `VirtualTable.test.tsx` has a new test that checks the header table's width matches its columns. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #43558 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
