bito-code-review[bot] commented on PR #44815:
URL: https://github.com/apache/superset/pull/44815#issuecomment-5903214631
<!-- Bito Reply -->
The flagged issue is already resolved in the provided PR diff. The changes
in
`superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts`
introduce a `pushAllTotal` method that lazily initializes `allTotal` using
`getFormattedAggregator(record)`. This ensures the grand total correctly adopts
the formatter of the metric being aggregated, rather than being pinned to a
default formatter in the constructor. No further implementation is required for
this specific issue.
**superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts**
```
pushAllTotal(record: PivotRecord) {
if (!this.allTotal) {
this.allTotal = this.getFormattedAggregator(record)(this, [], []);
}
this.allTotal.push(record);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
