codeant-ai-for-open-source[bot] commented on code in PR #44816:
URL: https://github.com/apache/superset/pull/44816#discussion_r4140627970
##########
superset/mcp_service/common/schema_discovery.py:
##########
@@ -365,6 +365,25 @@ def get_columns_from_model(
# UUID search separately and converts it to an exact ``uuid`` filter.
DATASET_SEARCH_COLUMNS = ["table_name", "description", "schema", "sql"]
DATASET_EXTRA_COLUMNS: dict[str, ColumnMetadata] = {
+ # Partition filter mapping. Listed here rather than in
+ # `_COLUMN_DESCRIPTIONS` because `get_columns_from_model` walks
+ # `mapper.columns`, and these are read-only properties over the mapping
+ # store, not columns -- a description there would never be reached.
+ "partition_column": ColumnMetadata(
+ name="partition_column",
+ description="Physical column the engine partitions on",
+ type="str",
+ is_default=False,
+ ),
Review Comment:
**Suggestion:** `partition_column` is advertised as selectable, but
`DatasetInfo` has no matching field, so Pydantic drops it from every MCP
dataset response.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=44c4feaecbfe4ae09f70211ee92ac43a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=44c4feaecbfe4ae09f70211ee92ac43a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/common/schema_discovery.py
**Line:** 372:377
**Comment:**
*Api Mismatch: `partition_column` is advertised as selectable, but
`DatasetInfo` has no matching field, so Pydantic drops it from every MCP
dataset response.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44816&comment_hash=4c6e3bd9a9556c4ca96a8645ee88019aa284f298ae2afc087b24d86a643485cd&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44816&comment_hash=4c6e3bd9a9556c4ca96a8645ee88019aa284f298ae2afc087b24d86a643485cd&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
