aminghadersohi commented on PR #44703: URL: https://github.com/apache/superset/pull/44703#issuecomment-5903853613
@rebenitez1802 @EnxDev all three optional nits from the approval are addressed in 10a7b0242f, on top of a master merge (f174f9498a): 1. `headers`, `rows_key` and `columns_key` are keyword-only on `_fetch_page_via_cursor`. 2. `test_opendistro_cursor_later_pages_and_exhaustion` covers page 2 and the exhaustion branch with `schema`/`datarows`. 3. A comment notes that `alias` comes only from the OpenSearch schema. The `headers is None` branch is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
