aminghadersohi commented on PR #44705: URL: https://github.com/apache/superset/pull/44705#issuecomment-5903947383
Following up on the bito review (run #ba9e90) and the bito reply that agreed with codeant: - **"Misleading credential set contract"**: fixed in c5e4c5e. The `access_token` exception in the filter is gone. `impersonate_user` drops every key in `DATABRICKS_SHARED_CREDENTIAL_CONNECT_ARGS` and then writes the user's token back explicitly. The comment on the constant now describes that contract. - **"Missing mock type annotation"**: the `database` mocks in the tests this PR adds are annotated as `MagicMock` in c5e4c5e. - **codeant/bito on the shared token only in the secure extra**: answered in the thread. The user's token reaches the connector through the URL password that `impersonate_user` sets. `test_impersonation_with_shared_token_only_in_secure_extra` (5e30ad1) covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
