rusackas commented on code in PR #44818:
URL: https://github.com/apache/superset/pull/44818#discussion_r4141648589
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -1100,14 +1083,7 @@ export function getTemporalTickValues(
}
const values = new Set<number>();
data.forEach(row => {
- const value = row[xAxisLabel];
- const timestamp =
- // eslint-disable-next-line no-nested-ternary
- value instanceof Date
- ? value.getTime()
- : typeof value === 'string'
- ? parseTemporalString(value)
- : Number(value ?? NaN);
+ const timestamp = coerceTemporalMs(row[xAxisLabel]);
Review Comment:
That local-midnight parsing already existed for tick placement, just
relocated from `series.ts` here. Codeant's right that `evalFormula`'s UTC
parsing in `annotation.ts` does not match it, but that mismatch predates this
PR and is a separate fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
