aminghadersohi commented on PR #44706:
URL: https://github.com/apache/superset/pull/44706#issuecomment-5906135378
@fitzee thanks for the live Db2 check. Both points are addressed in ce7c64b:
- **Trade-off:** the `get_prequeries` docstring now states that a quoted
lower-case schema (`CREATE SCHEMA "lowonly"`) resolves to `LOWONLY`, matching
`get_table_names`, so it isn't reachable through unqualified names in SQL Lab.
- **Test nit:** `test_get_prequeries` no longer re-implements
`denormalize_name`. It builds the real dialect with
`make_url("db2+ibm_db://u:p@h/d").get_dialect()()`, and
`pytest.importorskip("ibm_db_sa")` skips it when the driver isn't installed.
- CI doesn't install `ibm-db-sa` (no Linux arm64 wheel; see
`requirements/development.in`), and the testcontainers db2 job only runs `-m
testcontainers`. So the same assertions also run against SQLAlchemy's own
`DefaultDialect` normalization with `requires_name_normalize = True`. It
returns the same result as ibm_db_sa 0.4.4 for every input in the test.
- With ibm_db_sa installed locally, both variants pass, and both fail with
the denormalization removed.
Master is merged in and CI is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
