dpgaspar commented on a change in pull request #8725: Docker support
URL: 
https://github.com/apache/incubator-superset/pull/8725#discussion_r353059444
 
 

 ##########
 File path: docker/pythonpath_dev/superset_config.py
 ##########
 @@ -14,9 +14,21 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+
+#
+# This file is included in the final Docker image and SHOULD be overridden when
+# deploying the image to prod. Settings configured here are intended for use 
in local
+# development environments. Also note that superset_config_docker.py is 
imported
+# as a final step as a means to override "defaults" configured here
+#
+
+import logging
 import os
 
 
+logger = logging.getLogger()
+
 
 Review comment:
   nit: Can you change single quotes to double quotes on this file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to