dpgaspar commented on a change in pull request #8725: Docker support
URL: 
https://github.com/apache/incubator-superset/pull/8725#discussion_r353060153
 
 

 ##########
 File path: docker/docker-entrypoint.sh
 ##########
 @@ -15,24 +15,15 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-set -ex
+set -eo pipefail
 
-if [ "$#" -ne 0 ]; then
-    exec "$@"
-elif [ "$SUPERSET_ENV" = "development" ]; then
-    celery worker --app=superset.sql_lab:celery_app --pool=gevent -Ofair &
-    # needed by superset runserver
-    (cd superset/assets/ && npm ci)
-    (cd superset/assets/ && npm run dev) &
-    FLASK_ENV=development FLASK_APP="superset.app:create_app()" flask run -p 
8088 --with-threads --reload --debugger --host=0.0.0.0
-elif [ "$SUPERSET_ENV" = "production" ]; then
-    celery worker --app=superset.sql_lab:celery_app --pool=gevent -Ofair &
-    exec gunicorn --bind  0.0.0.0:8088 \
-        --workers $((2 * $(getconf _NPROCESSORS_ONLN) + 1)) \
+if [ "${#}" -ne 0 ]; then
+    exec "${@}"
+else
+    gunicorn --bind  "0.0.0.0:${SUPERSET_PORT}" \
+        --workers 1 \
         --timeout 60 \
         --limit-request-line 0 \
         --limit-request-field_size 0 \
         "superset.app:create_app()"
 
 Review comment:
   Replace `superset.app:create_app()` by `${FLASK_APP}`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to