rusackas commented on PR #43180: URL: https://github.com/apache/superset/pull/43180#issuecomment-5916023784
Still hoping someone (anyone) can test this out a bit and provide some screenshots. Really, we just need a good E2E test here that *proves* labels work as expected for all the use cases we've learned to care about. That's potentially a lot of OCD work to build it out using example datasets and (perhaps) screenshot diffs if we can't assert on DOM nodes, but it's worth doing, otherwise I'll be forever afraid to merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
