bito-code-review[bot] commented on code in PR #44739: URL: https://github.com/apache/superset/pull/44739#discussion_r4143461437
########## superset-frontend/src/components/FilterableTable/sortResults.test.ts: ########## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { decimalParts, sortResults } from './sortResults'; + +test.each([ + ['2', '10', -1], + [ + '12345678901234567890.123456789012345678', + '12345678901234567890.123456789012345679', + -1, + ], + [ + '-12345678901234567890.123456789012345678', + '-12345678901234567890.123456789012345679', + 1, + ], + ['1E-18', '0.000000000000000002', -1], + ['1E+100000', '9E+99999', 1], + ['1E-100000', '9E-100001', 1], + ['0.00000000000000000001', '0', 1], + ['0010.500', 10.5, 0], + ['-0.00', 0, 0], + ['.5', '0.50', 0], + ['9.99', 10, -1], + [null, '1.23', 1], + ['1.23', null, -1], + [null, null, 0], + ['apple', 'pear', -1], + ['2024-01-01', '2025-01-01', -1], + ['-Infinity', '-1.2', -1], + ['Infinity', '1.2', 1], +] as const)('sorts %s vs %s exactly', (a, b, expected) => { + expect(sortResults(a, b)).toBe(expected); +}); + +test.each([ + ['apple', 5], + ['apple', 'NaN'], + [NaN, 1.5], + ['2024-01-01', 7], +] as const)('orders %s against %s in one direction only', (a, b) => { + expect(sortResults(a, b)).toBe(-sortResults(b, a)); +}); + +test('treats two NaNs as equal rather than unordered', () => { + expect(sortResults(NaN, NaN)).toBe(0); + expect(sortResults('NaN', 'NaN')).toBe(0); +}); + +test('sorts a mixed text and number column transitively', () => { + const column = [5, 'apple', 'NaN', 10, 'banana']; + const ascending = [...column].sort(sortResults); + const descending = [...column].reverse().sort(sortResults); + expect(descending).toEqual(ascending); +}); + +test.each([ + [[9, '5x', 10]], + [[10, 9, '5x']], + [['5x', 10, 9]], + [['9', '5x', '10']], + [['10', '9', '5x']], + [['5x', '10', '9']], +])('sorts numbers before text whatever the input order: %p', column => { + const sorted = [...column].sort(sortResults).map(String); + expect(sorted).toEqual(['9', '10', '5x']); +}); Review Comment: <!-- Bito Reply --> The reviewer's suggestion to nest the test cases is based on the assumption that `test.each` spreads the array row into positional arguments. However, as you noted, the current implementation correctly passes the entire inner array as a single column argument, and the tests pass as expected. Therefore, no changes are required to the test code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
