sadpandajoe commented on PR #44588:
URL: https://github.com/apache/superset/pull/44588#issuecomment-5916621007
@rusackas — both fixed, thanks for catching these:
1. **`babel-extract` failure**: the missing `messages.pot` entry for `"No
sort (original order)"` was added in `79c83928`.
`babel-extract`/`frontend-check-translations` are green on the current HEAD.
2. **Closing the loop on the ordinal-values thread**: the opt-out itself
landed in `ac0301d3` (before your review, just not called out explicitly in
that thread at the time) — an explicit `'none'` ("No sort (original order)")
choice on the Sort Y Axis control that persists a non-null value, so it
survives the existing default-filling logic and gives users with ordinal Y-axis
values (`Low/Medium/High`, weekdays, etc.) a real, recoverable way to opt out.
Covered by a test in `transformProps.test.ts`. There's also a follow-up
refactor (`3ac27e4`) extracting the `'none'`/`'alpha_asc'` sentinel into a
shared constant between `controlPanel.tsx` and `transformProps.ts`.
All required checks are green on the current HEAD. Would appreciate a
re-review when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
