Re: [PR] chore(e2e): remove Cypress infrastructure [superset]

via GitHub Wed, 30 Sep 2026 11:05:40 -0700


codeant-ai-for-open-source[bot] commented on code in PR #44829:
URL: https://github.com/apache/superset/pull/44829#discussion_r4147770436



##########
.pre-commit-config.yaml:
##########
@@ -105,10 +105,9 @@ repos:
         files: ^docs/.*\.(js|jsx|ts|tsx)$
       - id: type-checking-frontend
         name: Type-Checking (Frontend)
-        entry: ./scripts/check-type.js package=superset-frontend 
excludeDeclarationDir=cypress-base
+        entry: ./scripts/check-type.js package=superset-frontend

Review Comment:
   **Suggestion:** This invokes the checker with pre-commit filenames; it 
builds `tsc --project ... file.ts`, which TypeScript rejects because project 
mode cannot be combined with source files.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Api mismatch`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c523ce63680f466e90d968e43f1fe315&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c523ce63680f466e90d968e43f1fe315&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** .pre-commit-config.yaml
   **Line:** 108:108
   **Comment:**
        *Api Mismatch: This invokes the checker with pre-commit filenames; it 
builds `tsc --project ... file.ts`, which TypeScript rejects because project 
mode cannot be combined with source files.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44829&comment_hash=d8960780ed23faef58c9eaba3a85a85315cec8ede385e4703d3a91e1e377ee85&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44829&comment_hash=d8960780ed23faef58c9eaba3a85a85315cec8ede385e4703d3a91e1e377ee85&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(e2e): remove Cypress infrastructure [superset]

Reply via email to