mikebridge commented on code in PR #44370:
URL: https://github.com/apache/superset/pull/44370#discussion_r4147922620
##########
superset-frontend/src/components/Chart/ChartRenderer.test.tsx:
##########
@@ -483,3 +500,32 @@ test('does not render chart during loading when last data
has errors', () => {
const { queryByTestId } = render(<ChartRenderer {...props} />);
expect(queryByTestId('mock-super-chart')).not.toBeInTheDocument();
});
+
+test('chart mask updates preserve incoming selection provenance', () => {
+ const updateDataMask = jest.fn();
+ render(
+ <ChartRenderer
+ {...requiredProps}
+ latestQueryFormData={{
+ datasource: '7__semantic_view',
+ viz_type: 'table',
+ semantic_selection_version: 'cube-member-id-v1',
Review Comment:
Thanks for verifying the clause-level mutations. That regression is retained
through the master merge in `014db3dde3`; the focused ChartRenderer suite
passes on this head.
##########
superset-frontend/src/explore/components/controls/MatrixifyDimensionControl.tsx:
##########
@@ -349,14 +357,22 @@ export default function MatrixifyDimensionControl(
/>
}
mode="multiple"
+ allowNewOptions={suggestionsDisabled}
Review Comment:
Added the members-mode normal-suggestions case in `014db3dde3`. It exercises
the real Select, waits for its search debounce, and verifies that an unknown
value cannot be added. Replacing the binding with constant `true` fails the
test; restoring it passes. The unavailable-suggestions manual-entry case still
passes.
##########
superset-frontend/src/explore/components/controls/MatrixifyDimensionControl.tsx:
##########
@@ -149,6 +151,12 @@ export default function MatrixifyDimensionControl(
signal,
endpoint,
});
+ if (signal.aborted) return;
+ if (json.suggestions_status === 'unavailable_versioned_view') {
+ setSuggestionsDisabled(true);
+ setValueOptions([]);
+ return;
Review Comment:
Confirmed the silent empty state. In `014db3dde3`, All mode explains that it
cannot refresh values for a versioned view and directs new selections to
Members for manual entry. Saved values remain intact and the members picker
stays hidden in All mode. Red-first tests cover fresh and saved selections
under both alphabetical sorts; the limitation is also documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
