aminghadersohi commented on code in PR #44682:
URL: https://github.com/apache/superset/pull/44682#discussion_r4148322733
##########
superset/mcp_service/server.py:
##########
@@ -681,6 +681,27 @@ async def _get_visible_tools(self, ctx: Context) ->
Sequence[Any]:
tools = await super()._get_visible_tools(ctx)
return _filter_tools_by_current_user_permission(tools)
+ async def _search(self, tools: Sequence[Tool], query: str) ->
Sequence[Tool]:
Review Comment:
Implemented in df0f307a965b2b55d0eda3ae6d1e283593a8145e: both BM25 and regex
use one shared exact-name promotion helper, considering only caller-visible
candidates before the final result limit. BM25 behavior and its existing tests
are unchanged. Added regex coverage for crowded sibling descriptions,
hidden/pinned tools, deduplication, limits, and unchanged non-exact ordering;
updated the docs. Search-transform and server tests: 111 passed. Pre-commit
checks, including mypy, passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
