sadpandajoe opened a new pull request, #44839: URL: https://github.com/apache/superset/pull/44839
### SUMMARY Adds a direct unit test for `saveModalReducer`. It previously ran only indirectly, through a version-history test that dispatches a stand-in hydrate action, so the real `HYDRATE_EXPLORE` handler was never exercised. The new tests cover each action handler, and in particular: - `SAVE_SLICE_SUCCESS` sets `lastSavedChart` only when `data.id` is a number and otherwise keeps the previous value. - `HYDRATE_EXPLORE` resets transient modal state to `payload.saveModal` but preserves `lastSavedChart` (including when the payload has no `saveModal`), because hydration can be batched with a save success. - An unknown action returns the same state reference. Test-only change; no production code is modified. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS ``` cd superset-frontend npx jest src/explore/reducers/saveModalReducer.test.ts ``` Also confirmed the tests fail when the `lastSavedChart` handling in `SAVE_SLICE_SUCCESS` or `HYDRATE_EXPLORE` is broken. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
