codeant-ai-for-open-source[bot] commented on code in PR #44843: URL: https://github.com/apache/superset/pull/44843#discussion_r4150580976
########## superset-frontend/src/explore/components/controls/ColumnConfigControl/ControlForm/ControlForm.test.tsx: ########## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + render, + screen, + userEvent, + within, + waitFor, +} from 'spec/helpers/testing-library'; +import ControlForm, { ControlFormItem, ControlFormRow } from '.'; + +const noDigits = (value: unknown) => + /\d/.test(String(value)) ? 'Digits are not allowed' : false; + +const renderForm = ( + props: { + value?: Record<string, string>; + validators?: ((value: unknown) => string | false)[]; + debounceDelay?: number; + } = {}, +) => { + const onChange = jest.fn(); + render( + <ControlForm onChange={onChange} value={props.value}> + <ControlFormRow> + <ControlFormItem + name="title" + controlType="Input" + label="Title" + description="Title description" + validators={props.validators} + debounceDelay={props.debounceDelay} + /> + <ControlFormItem + name="note" + controlType="Input" + label="Note" + description="Note description" + /> + </ControlFormRow> + </ControlForm>, + ); + return { onChange }; +}; + +test('seeds each field from the matching key of the form value', () => { + renderForm({ value: { title: 'Hello', note: 'World' } }); + expect( + screen + .getAllByRole('textbox') + .map(input => (input as HTMLInputElement).value), + ).toEqual(['Hello', 'World']); +}); + +test('propagates an edit to the form merged with the existing value', async () => { + const { onChange } = renderForm({ value: { note: 'World' } }); + await userEvent.type(screen.getAllByRole('textbox')[0], 'Hi'); + + await waitFor(() => + expect(onChange).toHaveBeenLastCalledWith({ note: 'World', title: 'Hi' }), + ); +}); Review Comment: **Suggestion:** This test edits only `title`, so it cannot catch debounced edits to two fields overwriting each other from stale form values. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Race condition` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c301b51701dc4cdc96e5eba377d8b531&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c301b51701dc4cdc96e5eba377d8b531&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/src/explore/components/controls/ColumnConfigControl/ControlForm/ControlForm.test.tsx **Line:** 71:78 **Comment:** *Race Condition: This test edits only `title`, so it cannot catch debounced edits to two fields overwriting each other from stale form values. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44843&comment_hash=169e37030bf8b436c87b97d8e59241eb3d4203e2840d01557b7d8b8dc2fc248e&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44843&comment_hash=169e37030bf8b436c87b97d8e59241eb3d4203e2840d01557b7d8b8dc2fc248e&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
