sadpandajoe opened a new pull request, #44846:
URL: https://github.com/apache/superset/pull/44846
### SUMMARY
The per-visualization Cypress specs stopped running in #36538, once example
data moved to YAML and broke their hardcoded dataset and slice ids. They were
later deleted as dead code in #40384. This is one of three small PRs that
restore the meaningful parts of that coverage at the right tier, rather than
re-porting each spec one-to-one.
This PR fills the remaining small unit and RTL gaps:
- **`ColorSchemeControl.test.tsx`**:
- Selecting a scheme calls `onChange` with its id.
- Searching filters the options by label.
- An `isLinear` (sequential) scheme can be selected. The old Cypress
color-scheme specs only typed into the search box and never selected an option.
- **BigNumber** (`transformProps.test.ts`, `BigNumberViz.test.tsx`):
- The comparison subheader is omitted when `compareLag` is absent or null,
and a configured subheader is kept.
- The trendline is rendered only when `showTrendLine` is true.
- **`WorldMap.test.ts`**: bubbles are drawn when `showBubbles` is true and
are absent when it is false. The existing `mockBubbles` was never asserted.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (tests only)
### TESTING INSTRUCTIONS
```bash
cd superset-frontend
npm run test -- src/explore/components/controls/ColorSchemeControl
plugins/plugin-chart-echarts/src/BigNumber plugins/plugin-chart-world-map/test
```
Each new test was checked against a mutation of the source it targets, and
it fails when that behavior is broken.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
