bito-code-review[bot] commented on PR #44844:
URL: https://github.com/apache/superset/pull/44844#issuecomment-5922272960
<!-- Bito Reply -->
The flagged issue is correct. In the current implementation, the test
iterates through all charts sequentially, and for each chart, it waits for
rendering with a timeout (`TIMEOUT.CHART_RENDER`). If many charts are slow to
render, the cumulative time can exceed the overall test timeout.
To resolve this, you can reduce the per-chart timeout or implement a more
efficient way to verify rendering. Since the goal is to ensure all charts
render, you could consider parallelizing the rendering checks or reducing the
`TIMEOUT.CHART_RENDER` value if the charts are expected to render faster.
Would you like me to implement a fix for this, or check the other comments
on this PR?
**superset-frontend/playwright/tests/dashboard/featured-charts-render.spec.ts**
```
await expect(
output,
`"${name}" (${formData.viz_type}) should render its output`,
).toBeVisible({ timeout: TIMEOUT.CHART_RENDER });
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
