kksingh000 commented on issue #44822: URL: https://github.com/apache/superset/issues/44822#issuecomment-5926427475
I'd like to pick up the language-classification half of this (the python/frontend directory-group conflation in change_detector.py's PATTERNS, referenced in the review discussion on PR #44699). The push-range half is already in progress in #44833, so I'll leave that alone. Before I start: on current master, codeql-analysis.yml's analyze job still runs the hardcoded ["python", "javascript"] matrix whenever python == 'true' || frontend == 'true' -- the per-language lang_matrix output that would actually consume a more accurate classification only exists on #44699's branch, which isn't merged yet. So fixing PATTERNS to be language-accurate on master today wouldn't change CodeQL's behavior until #44699 lands (or is rebased onto this). @hainenber -- is a standalone fix to PATTERNS (making python/frontend classify by file extension/language rather than directory) still useful to land ahead of #44699, or would you rather this be folded into that PR directly once it's further along? Don't want to duplicate work or build something that conflicts with how you're planning to finish #44699. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
