sadpandajoe commented on code in PR #44665:
URL: https://github.com/apache/superset/pull/44665#discussion_r4154814356
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -1316,19 +1391,19 @@ export default function TableChart<D extends DataRecord
= DataRecord>(
// render `Cell`. This saves some time for large tables.
return (
<StyledCell {...cellProps}>
- {valueRange && (
+ {cellDrawsBar ? (
<div
/* The following classes are added to support custom CSS
styling */
className={cx(
'cell-bar',
- typeof value === 'number' && value < 0
+ numericValue !== undefined && numericValue < 0
? 'negative'
: 'positive',
)}
- css={cellBarStyles}
+ style={cellBarStyles}
Review Comment:
Moving the bar color and geometry into inline styles overrides existing
dashboard CSS such as `.cell-bar.positive { background-color: red; }`, so saved
custom styling stops working unless users add `!important`. Could these
properties stay in an overridable stylesheet while keeping the width assertions
testable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
