gabotorresruiz commented on PR #44765: URL: https://github.com/apache/superset/pull/44765#issuecomment-5937587018
@rusackas both of your points landed in `36af4d33`, which went in after your review, so the head has moved past the commit you blocked at. On the retry guard you were right, and it was measurable. On `54572820` the SQL executor shape exchanged the token twice for one logical query and the request succeeded through a nested inner retry. On this head it exchanges once and returns the sign-in redirect instead. The guard is now set around the retried call and the whole thing sits inside `check_for_oauth2(database)`. On the inspector, `open_inspector` picked up the `check_for_oauth2(self)` wrapping, with tests for both the rejected replacement token and an exception thrown back from the caller's block. Both of those fail against master. I approved at `ed86e158`. The only red checks are the two `Analyze` jobs, failing with a CodeQL configuration error that hit several unrelated branches in the same hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
