codeant-ai-for-open-source[bot] commented on code in PR #44849:
URL: https://github.com/apache/superset/pull/44849#discussion_r4159909371
##########
superset/semantic_layers/models.py:
##########
@@ -257,9 +259,18 @@ def after_delete(
security_manager.semantic_layer_after_delete(mapper, connection,
target)
- @cached_property
+ @property
def implementation(
self,
+ ) -> SemanticLayerABC[Any, SemanticViewABC]:
+ if metadata_binding.participates(self):
+ # Read authorization belongs to callers with full request context.
+ return metadata_binding.layer_implementation(self)
+ return self._legacy_implementation
+
+ @cached_property
+ def _legacy_implementation(
+ self,
) -> SemanticLayerABC[Any, SemanticViewABC]:
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag the legacy provider's existing caching behavior as stale when
configuration is unchanged; preserve the flag-off contract and only invalidate
or refresh providers when stored configuration changes.
**Applied to:**
- `superset/semantic_layers/models.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
