rusackas commented on PR #44206: URL: https://github.com/apache/superset/pull/44206#issuecomment-5943407483
Thanks @mikebridge, this is looking good, and it's nice that it's all driven off the existing run report with no new endpoints. I'd love another pass on a couple of the open bot threads before this gets merged. Codeant's point that `getChartKey` needs a `slice_id` that `latestQueryFormData` usually doesn't carry seems valid, since saved charts would read key `0` and show nothing. Bito and Codeant are also both right that a failed chart ends up with "No provider query is available for this run" instead of its actual error. Could you take a look and resolve those? The translation thread is fine to ignore, empty `msgstr` is expected for new strings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
