rusackas commented on PR #44431: URL: https://github.com/apache/superset/pull/44431#issuecomment-5943443341
Thanks @eschutho, the engine gating makes sense, and splitting the oxfmt reformat out was a nice touch for review. Of @sadpandajoe's threads are still open, I think the `exploreReducer.ts` one is the most important, since dropping the `key !== controlName` guard looks like it brings back the stale `time_range` value issue. The query-time `resolve_partition_mapping()` not checking the new flag (existing mappings go invisible but stay active) and the capability not refreshing when the database is changed in the editor also seem worth sorting out. Also, could you take a look at those and resolve or reply on each? I'd love to get this in once they're settled, holler if you want a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
