mikebridge commented on PR #44874: URL: https://github.com/apache/superset/pull/44874#issuecomment-5943441162
On the gauge coverage: agreed, nothing was asserting `_report_model_counts`. fe43b27f03 captures the gauge in the mixed-registry test and asserts the three names and values for both the purged and dry-run paths. Checked by mutation: removing the dry-run reporting call fails only the dry-run case, and removing the live call fails only the live case. One caveat on local verification: the full unit suite on my machine has 51 failures in unmodified files (sqlglot below the pinned version, plus timezone and ARM long-double cases), none in deletion-retention, so CI on this head is the real check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
