rusackas commented on PR #43693: URL: https://github.com/apache/superset/pull/43693#issuecomment-5943683291
Pushed 2492275: - Rebased onto current master (this branch was ~279 commits stale) — the failing checks were a stale pot-drift/docker-cache-version mismatch already fixed on master since this branch's last sync, not an issue with the pivot fix itself. - Fixed the one open bito-code-review finding: the datetime branch of `_fill_dimension_column` was casting the whole column to `str`, which also stringified every non-null `Timestamp` value, not just the NaT positions. Switched to `astype(object)` so non-null entries stay real `Timestamp` objects; added a regression test for it. - Resolved the two earlier sadpandajoe threads (categorical unobserved-bucket guard, nullable extension dtype cast) — confirmed those fixes are already in the history, just under a new SHA post-rebase. Will keep an eye on CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
