hughhhh commented on code in PR #43870:
URL: https://github.com/apache/superset/pull/43870#discussion_r4162113317
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -406,7 +408,12 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
{...props}
onDescriptionHoverChange={setIsDescriptionHovered}
/>
- {popoverContent}
+ {/* The glyph sits outside the popover trigger so clicking it opens the
+ tooltip rather than the time-range editor. */}
+ <Flex align="center" gap={theme.sizeUnit}>
+ {popoverContent}
+ <PartitionPruningIndicator mapping={props.partitionMapping} />
Review Comment:
Fixed in `f06a9ad100` / `46e4cd7c54` (earlier on this branch) +
`1e132aefc9`. The control is handed a mapping only when the range resolves to a
bound and the selected temporal column is the mapped one. `1e132aefc9` closed
the two holes left in that gate: a `time_range` that is absent rather than `No
filter`, and the `always_filter_main_dttm` path firing with no granularity
selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
