bito-code-review[bot] commented on PR #44617:
URL: https://github.com/apache/superset/pull/44617#issuecomment-5943005468
<!-- Bito Reply -->
The suggestion to use conditional wording like "may change" or "may break"
is appropriate. The current implementation uses absolute language ("will
change", "will break") in the warning alert, which may be inaccurate for
engines where normalization is a no-op or casing is already compatible.
Updating the message, translation catalog, and the corresponding test assertion
to reflect this uncertainty would improve the accuracy of the user feedback.
**superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx**
```
message={t(
'Changing this setting will change the casing for all
columns in this dataset, ' +
'which will break any existing charts and dashboard
filters that reference the ' +
'current column names.',
)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
