rusackas opened a new pull request, #44881: URL: https://github.com/apache/superset/pull/44881
### SUMMARY Investigating #41268: on an embedded dashboard, a role lacking `can_explore` but holding `can_view_chart_as_table` + `can_get_drill_info` sees "View as table" silently never finish loading, while an Admin on the same chart sees it render fine. `SliceHeaderControls.test.tsx` mocks `ResultsPaneOnDashboard` entirely, so the existing permission tests only confirm the `drill_info` fetch fires and `verbose_map` gets computed for that role -- none of them render the real results grid. This adds that missing coverage: the real `ResultsPaneOnDashboard`, under the reporter's exact permission profile and chart shape (a grouped `COUNT` metric plus a `contribution` post-processing column, matching their pasted API response), actually renders the fetched rows and row count, and doesn't get stuck loading if `drill_info` itself fails. Both new tests pass against current master. The most plausible explanation: #43719 (merged 2026-09-07, after this issue's last reporter activity) fixed the `drill_info` endpoint this pane depends on for column labels -- pre-fix, the endpoint's schema had no `metrics` field at all and narrowed `columns` to dimensions only, and the frontend's skip-predicate for the fetch didn't match the set of users "View as table" is offered to. Either way, this test locks the now-correct behavior in as a regression guard, and gives #41268 a concrete, reproducible basis for closing. ### TESTING INSTRUCTIONS ```bash cd superset-frontend npx jest src/dashboard/components/SliceHeaderControls/ViewAsTableRendering.test.tsx ``` Also ran the full `SliceHeaderControls`/`DataTablesPane` suites (102 tests, 9 suites) to confirm no interference with existing coverage. ### ADDITIONAL INFORMATION - [x] Has associated issue: #41268 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
