codecov-io edited a comment on issue #8712: guard against duplicate columns in datasource save URL: https://github.com/apache/incubator-superset/pull/8712#issuecomment-560556899 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=h1) Report > Merging [#8712](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/871af05f681f1a9f3383beda1037dd5fa5905683?src=pr&el=desc) will **increase** coverage by `0.43%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #8712 +/- ## ========================================== + Coverage 65.4% 65.83% +0.43% ========================================== Files 482 482 Lines 24083 24123 +40 Branches 2763 2767 +4 ========================================== + Hits 15751 15882 +131 + Misses 8152 8061 -91 Partials 180 180 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `96.15% <100%> (+1.03%)` | :arrow_up: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `74.73% <0%> (-1.97%)` | :arrow_down: | | [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `2.36% <0%> (-0.03%)` | :arrow_down: | | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.68% <0%> (ø)` | :arrow_up: | | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100% <0%> (ø)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.52% <0%> (+0.04%)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.9% <0%> (+0.04%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.95% <0%> (+0.13%)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.5% <0%> (+0.22%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.85% <0%> (+0.24%)` | :arrow_up: | | ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/8712/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=footer). Last update [871af05...70f291d](https://codecov.io/gh/apache/incubator-superset/pull/8712?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
