alexandrusoare commented on code in PR #44892: URL: https://github.com/apache/superset/pull/44892#discussion_r4165609720
########## docs/docs/using-superset/recently-archived.mdx: ########## @@ -123,7 +123,18 @@ Each skip increments `deletion_retention.unsupported_models.<table>` once per run. Unsupported models are excluded from `would_purge` and do not count as `cascade_failures`; supported models continue to use their existing policies. An empty `unsupported_models` map means no registered models were skipped for -this reason. This reporting does not add purge support for host-defined models. +this reason. This reporting does not itself add purge support for host-defined +models. + +A host distribution that carries its own soft-deletable entities can supply +their purge behavior by installing `PURGE_POLICIES_FUNC`: a callable returning +one `PurgeEntityPolicy` per root it owns. Installed policies are validated +against the discovered dependency graph exactly as the built-in ones are, and a +model that gains an installed policy stops being reported as unsupported. A +provider that fails, returns something other than a sequence of policies, or +redeclares a built-in chart, dashboard or dataset root is logged and ignored, +leaving the built-in roots unchanged. Hosts can require +`superset.versioning.utils.HOST_POLICY_API_VERSION` before installing. Review Comment: Agreed — I'd already dropped the version bump, so that line pointed at a signal that no longer exists. The docs now say to check for HOST_POLICIES_CONFIG_KEY in the purge module, which tracks the hook directly and fails closed on a rollback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
