codeant-ai-for-open-source[bot] commented on code in PR #44894:
URL: https://github.com/apache/superset/pull/44894#discussion_r4166236914
##########
superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx:
##########
@@ -380,7 +381,19 @@ const AsyncSelect = forwardRef(
// merges with existing and creates unique options
setSelectOptions(prevOptions => {
mergedData = prevOptions
- .filter(previousOption => !dataValues.has(previousOption.value))
+ .filter(previousOption => {
+ if (dataValues.has(previousOption.value)) {
+ return false;
+ }
+ if (
+ previousOption.isNewOption &&
+ (hasOption(previousOption.label as V, data, true) ||
+ hasOption(previousOption.value as V, data, true))
+ ) {
Review Comment:
**Suggestion:** `hasOption` checks only top-level entries, so matching
children inside grouped `options` are missed and the optimistic entry remains
beside the fetched option.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=46b358ab2e644c75adc1d28285211bcb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=46b358ab2e644c75adc1d28285211bcb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx
**Line:** 388:392
**Comment:**
*Logic Error: `hasOption` checks only top-level entries, so matching
children inside grouped `options` are missed and the optimistic entry remains
beside the fetched option.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44894&comment_hash=f4ef677ab67b8b4799be4ac8f48c047a4a1b22bd19493fe6728cd0ada8126c8e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44894&comment_hash=f4ef677ab67b8b4799be4ac8f48c047a4a1b22bd19493fe6728cd0ada8126c8e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
