tien238lnd commented on PR #44339: URL: https://github.com/apache/superset/pull/44339#issuecomment-5948477532
Checking in on this one — it has been quiet since 25/09 and I do not think anything is outstanding. @aminghadersohi verified the last two rounds by mutation (every skip in `get_user_role_names` logs at debug, the per-group read is real, and reverting either reds exactly one of the two new tests), the docstring notes are addressed, and the N+1 thread is settled: `list_users` cannot reach the relationships because `roles` is not in `USER_ALL_COLUMNS`, and `get_user_info` eager-loads them. CI is green and the branch is mergeable. It needs one approval. The bug it fixes is small but has teeth: a user who holds roles only through a group reads back as `roles: []`, so anything deciding on that list treats them as unprivileged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
