joaopamaral commented on code in PR #44825:
URL: https://github.com/apache/superset/pull/44825#discussion_r4168180787
##########
superset/db_engine_specs/redshift.py:
##########
@@ -100,6 +102,13 @@ class RedshiftEngineSpec(BasicParametersMixin,
PostgresBaseEngineSpec):
max_column_name_length = 127
default_driver = "psycopg2"
+ # In Redshift a catalog is a database. Cross-database queries
+ # (`database.schema.table`) are supported natively, including for
+ # databases created from datashares.
+ supports_catalog = True
Review Comment:
Added `tests/unit_tests/migrations/test_enable_catalog_in_redshift.py`: runs
`e6d0a676a087`'s `upgrade()`/`downgrade()` over a Redshift dataset/chart/saved
query (URL database and IAM `connect_args.database`) next to a Postgres one:
checks catalog/perm conversion, the non-default catalog perms, Postgres left
untouched, and an exact permission round-trip. Also `test_catalog_support`
asserting the three flags. Flipping `supports_catalog` to `False` now fails
both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
