sdairs opened a new pull request, #44901: URL: https://github.com/apache/superset/pull/44901
### SUMMARY The ClickHouse database guide uses an outdated logo whose black wordmark disappears against the dark background. The database page also renders Ant Design text and cards in light mode when the surrounding docs use dark mode. Use the official ClickHouse SVG logos with separate light/dark variants and compact marks for ClickHouse Cloud and ClickHouse Managed Postgres. Add optional `logo_dark` metadata, respect Docusaurus’s theme selection, and keep existing single-variant logos legible on a white backing in dark mode. Connect the database page’s Ant Design theme to the docs theme switch. Also correct ClickHouse Connect’s transport from native TCP to HTTP(S), add a tested public ClickHouse Cloud SQL playground example before the own-service HTTPS template, and clarify installation, database credentials, URL encoding, and container networking. Add links to the driver and ClickHouse Superset documentation. Align ClickHouse and ClickHouse Cloud installation requirements with Superset’s `clickhouse-connect>=1.8.0,<2.0` dependency; the previous documented minimum connects but fails SQLAlchemy 2.0 schema discovery. Altinity Cloud connection examples, provider documentation, links, and legacy-driver instructions are unchanged. I work for ClickHouse. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF | Before (dark theme) | After (dark theme) | | --- | --- | |  |  | <details> <summary>Light theme and public playground example</summary>   </details> ### TESTING INSTRUCTIONS - Run the database documentation generator and component documentation generator, then start the docs site. - Open the ClickHouse database guide and switch between light, dark, and system theme. Check the header logo, title, description, cards, and the ClickHouse Cloud provider mark. - Open the PostgreSQL guide. Check the ClickHouse Managed Postgres mark and the white backing on logos that have no dark variant. - Check the recommended and legacy driver tabs. Confirm the public playground appears first, followed by the own-service Cloud HTTPS template and the unchanged Altinity example. Validation: pre-commit checks passed for changed files; the custom Superset pylint plugin passed directly against all three changed Python files (10/10). The docs dev build compiled successfully with existing warnings. TypeScript comparison returned the same 52 errors on the base and updated source, with no new errors. Actual pages were visually checked in light and dark mode. Live checks of `clickhousedb://demo:@sql-clickhouse.clickhouse.com:8443/uk?secure=true` passed with ClickHouse Connect 1.8.0 and SQLAlchemy 2.0.52: the same dialect ping used by Superset, discovery of 43 schemas and 9 UK tables, column reflection, bounded SQL and SQLAlchemy-generated sample queries, and a 257-row sample-table aggregation. HTTPS certificate verification remained enabled. The full Superset web UI and production documentation build were not run. The existing AST fallback generator combines inherited package lists and can list both ClickHouse drivers as required locally; this behavior also exists on the base. This patch preserves the tracked driver selection and does not change the generator. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
