codeant-ai-for-open-source[bot] commented on code in PR #44806:
URL: https://github.com/apache/superset/pull/44806#discussion_r4169917784
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -352,11 +353,36 @@ const config: ControlPanelConfig = {
description: t('Order results by selected columns'),
multi: true,
default: [],
- mapStateToProps: ({ datasource }) => ({
- choices: datasource?.hasOwnProperty('order_by_choices')
- ? (datasource as Dataset)?.order_by_choices
- : datasource?.columns || [],
- }),
+ mapStateToProps: ({ datasource, controls }) => {
+ if (datasource?.type === DatasourceType.SemanticView) {
+ const selectedColumns = [
+ ...new Set(
+ ensureIsArray(
+ controls?.all_columns?.value as
+ | QueryFormColumn[]
+ | undefined,
+ ).filter(isPhysicalColumn),
+ ),
+ ];
+ return {
+ choices: selectedColumns.flatMap(column => [
+ [
+ JSON.stringify([column, true]),
+ `${column} ${t('[asc]')}`,
+ ],
+ [
+ JSON.stringify([column, false]),
+ `${column} ${t('[desc]')}`,
+ ],
+ ]),
+ };
Review Comment:
**Suggestion:** Because this control has no `rerender` dependency on
`all_columns`, changing Columns does not recompute these choices, leaving
removed dimensions visible and new dimensions unavailable.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f39b307807234a73b2058742fe8143b7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f39b307807234a73b2058742fe8143b7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
**Line:** 356:378
**Comment:**
*Stale Reference: Because this control has no `rerender` dependency on
`all_columns`, changing Columns does not recompute these choices, leaving
removed dimensions visible and new dimensions unavailable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44806&comment_hash=de28dbc1d56d4242d403aa63931963e5b5ba930c77be3db26baa31718a7e8c09&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44806&comment_hash=de28dbc1d56d4242d403aa63931963e5b5ba930c77be3db26baa31718a7e8c09&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
