SBIN2010 opened a new pull request, #44907: URL: https://github.com/apache/superset/pull/44907
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY AG Grid table cells that hold a JSON object or array stay the original text. A click opens that value in a dialog titled "Cell content", with the structure expanded and a control that copies the original text, in the same spirit as the SQL Lab JSON viewer. **Customize → Options → JSON in cell** (off by default) collapses those values onto one line and adds an arrow on the left: - A click on the arrow expands and collapses the JSON in the row. Nested objects and arrays open one level at a time, and the row grows with the tree. - A double-click on the arrow opens the same dialog. The click waits a short moment so a double-click opens the dialog instead of toggling the tree twice. A double-click on the collapsed text does not open the dialog. Only values that parse as a JSON object or array are interactive. Plain text, URLs, and opt-in HTML cells are unchanged. Clicks on the JSON text and on the arrow do not select the row or apply a cross-filter. The control only changes rendering (`renderTrigger`), so it does not rerun the query. Charts that do not set the checkbox keep the original text and open the dialog on click. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> <img width="1752" height="883" alt="Снимок экрана от 2026-10-03 00-31-03" src="https://github.com/user-attachments/assets/5673eefa-98e9-42ea-87f4-3a9b7eac25e9"; /> <img width="1752" height="883" alt="Снимок экрана от 2026-10-03 00-34-12" src="https://github.com/user-attachments/assets/eb24442d-d4c9-4728-82ac-fa91dcc11e62"; /> <img width="1752" height="883" alt="Снимок экрана от 2026-10-03 00-34-42" src="https://github.com/user-attachments/assets/ad000b9d-ab3e-4fd1-808f-c15fa5888159"; /> ### TESTING INSTRUCTIONS 1. Create an AG Grid table chart with a text column whose values are JSON objects or arrays (text that starts with `{` or `[`). 2. Leave **Customize → Options → JSON in cell** unchecked. - The cell shows the original text, including line breaks, and has no arrow. - A click opens a dialog titled "Cell content". Copy writes the original text to the clipboard. 3. Check **JSON in cell**. The chart should not rerun the query. - The value collapses to one line and an arrow appears on the left. - A click on the arrow expands the structure in the row, including nested objects and arrays. Another click collapses it. - A double-click on the arrow opens the dialog. A double-click on the collapsed text does not. 4. Confirm plain text, URL, and HTML cells still render as before. 5. With cross-filters enabled, confirm a click on the JSON text or the arrow does not apply a cross-filter. A click on the collapsed preview text still can. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ x ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ x ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
