rusackas opened a new pull request, #44924: URL: https://github.com/apache/superset/pull/44924
### SUMMARY Adds testcontainers coverage for `OpenDistroEngineSpec.fetch_data_with_cursor` against a real OpenSearch instance, wired into `.github/workflows/testcontainers.yml`. OpenSearch forked from Elasticsearch, and its SQL plugin answers in a different, JDBC-style response shape (`schema`/`datarows` on the legacy `/_opendistro/_sql` endpoint Superset still targets, vs Elasticsearch's own `columns`/`rows`). #44703 fixed `fetch_data_with_cursor` reading the wrong keys (silently returning an empty page for anything past page 1) and sending a duplicate `Content-Type` header that opensearch-py's transport already sets, which OpenSearch rejects outright. Both regressions were already covered by mocked unit tests in `tests/unit_tests/db_engine_specs/test_elasticsearch.py`. This exercises the same code path against a real server's real response instead, which is the only way to catch a third, still-undiscovered shape surprise the mocks don't model. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - backend test coverage only. ### TESTING INSTRUCTIONS - `pytest -v -m testcontainers tests/testcontainers/db_engine_specs/test_opensearch.py` (requires Docker) - CI runs this automatically via the new `opensearch` entry in the `testcontainers` workflow matrix ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
