codeant-ai-for-open-source[bot] commented on code in PR #44905: URL: https://github.com/apache/superset/pull/44905#discussion_r4170273063
########## superset/semantic_layers/models.py: ########## @@ -829,6 +839,7 @@ def get_compatible_dimensions( sa.event.listen(SemanticLayer, "after_insert", SemanticLayer.after_insert) sa.event.listen(SemanticLayer, "before_update", SemanticLayer.before_update) +sa.event.listen(SemanticLayer, "before_delete", SemanticLayer.before_delete) Review Comment: **Suggestion:** Deleting a layer now performs multiple permission queries per child view, causing a large layer deletion to issue O(n) database round trips and become unnecessarily slow. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Performance` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=379b0db3fabe4dc685a890f48bc1dac0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=379b0db3fabe4dc685a890f48bc1dac0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/semantic_layers/models.py **Line:** 842:842 **Comment:** *Performance: Deleting a layer now performs multiple permission queries per child view, causing a large layer deletion to issue O(n) database round trips and become unnecessarily slow. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44905&comment_hash=dd512a3b498cae4bc1065aa8c7ce86dc284b878cf84fb234ae6d68ddf4f472de&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44905&comment_hash=dd512a3b498cae4bc1065aa8c7ce86dc284b878cf84fb234ae6d68ddf4f472de&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
