FrancescoCastaldi commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-5967836764
Addressed comments in commit 8a301f9: 1. \superset/db_engine_specs/lint_metadata.py\: fixed \AnnAssign\ scan to continue on bare annotations without initializer (\item.value is None\), allowing following assignments to be parsed. 2. \superset/db_engine_specs/parseable.py\: switched URI scheme to \parseable+http://\ in connection string and examples to avoid TLS failures on default port 8000. 3. \ ests/unit_tests/db_engine_specs/test_lint_metadata.py\: refactored tests to use pytest \ mp_path\ fixture with \SPECS_DIR\ monkeypatching (removing source dir pollution), and added \ est_get_all_engine_specs_ast_declaration_then_assignment\ regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
