sadpandajoe commented on code in PR #44208:
URL: https://github.com/apache/superset/pull/44208#discussion_r4172815151
##########
superset-frontend/src/pages/ActionLog/index.tsx:
##########
@@ -152,6 +152,9 @@ function ActionLogList() {
{
accessor: 'user',
Header: t('User'),
+ // The log API only orders by scalar fields (e.g. `user.username`),
+ // not the `user` relationship itself.
+ disableSortBy: true,
Review Comment:
Removing this guard would again send unsupported `order_column=user`, but
the current tests do not exercise Action Log’s disabled-sort behavior. Could we
add an interaction test that clicks User and then paginates, asserts that
requests never sort by `user`, and uses Action sorting as a positive control?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
