bito-code-review[bot] commented on code in PR #44953:
URL: https://github.com/apache/superset/pull/44953#discussion_r4174068641
##########
superset/models/helpers.py:
##########
@@ -2683,7 +2683,38 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
df = query_object.exec_post_processing(df)
except InvalidPostProcessingError as ex:
raise QueryObjectValidationError(ex.message) from ex
- except (TypeError, pd.errors.DataError) as ex:
+ # A post-processing operation is driven entirely by the request's
+ # `options` dict, which `ChartDataPostProcessingOperationSchema`
+ # accepts as an untyped `fields.Dict`. A malformed option therefore
+ # reaches pandas and surfaces as whatever pandas raises, so these
+ # are bad-request failures, not server faults. ImportError is
+ # deliberately excluded: a missing optional dependency (scipy, for
+ # a `rolling` win_type) is a deployment matter, not a bad request.
+ except KeyError as ex:
+ # Every KeyError an operation raises names a column or
+ # MultiIndex level the options asked for and the result does
+ # not have. `str(KeyError)` is only the repr'd key, which alone
+ # reads as a bare quoted string.
+ raise QueryObjectValidationError(
+ _(
+ "Post-processing references a column or level that is "
+ "not in the query result: %(name)s",
+ name=ex.args[0] if ex.args else ex,
+ )
+ ) from ex
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>KeyError Branch Unlogged</b></div>
<div id="fix">
The `KeyError` branch reports the failure to the client but logs nothing,
while the sibling broad-except branch logs at WARNING with `exc_info=True`,
citing that the caller reports the message without logging
(`query_context_processor.get_df_payload_result` sets `cache.error_message`;
`charts/data/api.py` returns `response_400`). Operations like `cum`, `diff`,
`rank`, `select` lack `validate_column_args`, so user-supplied missing columns
reach here; add the same warning so failures stay diagnosable.
</div>
</div>
<small><i>Code Review Run #0d1040</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
