sadpandajoe commented on code in PR #38069:
URL: https://github.com/apache/superset/pull/38069#discussion_r4174554083
##########
superset-frontend/src/components/Chart/chartAction.ts:
##########
@@ -930,8 +929,11 @@ export function redirectSQLLab(
requestedQuery: payload,
});
} else {
- SupersetClient.postForm(ensureAppRoot(redirectUrl), {
- form_data: safeStringify(payload),
+ SupersetClient.postForm({
Review Comment:
The existing endpoint tests start with a bare path, so they would not catch
this caller adding the app-root prefix again and sending SQL Lab navigation to
`/analytics/analytics/sqllab/`. Could `chartActions.test.ts` exercise
`redirectSQLLab` without `history` under a non-empty app root and assert the
bare `/sqllab/` endpoint plus the serialized query payload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
