hainenber commented on code in PR #44965:
URL: https://github.com/apache/superset/pull/44965#discussion_r4178647290
##########
superset-frontend/webpack.config.js:
##########
@@ -107,6 +106,23 @@ const output = {
pathData.chunk?.name === 'service-worker'
? '../service-worker.js'
: defaultChunkFilename,
+ copy: [
+ 'package.json',
+ { from: 'src/assets/images', to: 'images' },
+ // maplibre-gl 6's ESM-only build loads its worker from a real URL
+ // instead of an inlined blob (see MapLibre.tsx for the matching
+ // maplibregl.setWorkerUrl() call). The worker's own bundle does a
+ // relative ESM import of its "shared" chunk, so both files must be
+ // copied verbatim, unhashed, into the same output directory.
+ {
+ from: 'node_modules/maplibre-gl/dist/maplibre-gl-worker.mjs',
+ to: 'maplibre-gl-worker.mjs',
Review Comment:
Thanks Joe, this is a correct. I've fixed in
3c7d4550bcb46a0ed071baa253262801c9cb026e
##########
superset-frontend/webpack.config.js:
##########
@@ -107,6 +106,23 @@ const output = {
pathData.chunk?.name === 'service-worker'
? '../service-worker.js'
: defaultChunkFilename,
+ copy: [
+ 'package.json',
+ { from: 'src/assets/images', to: 'images' },
+ // maplibre-gl 6's ESM-only build loads its worker from a real URL
+ // instead of an inlined blob (see MapLibre.tsx for the matching
+ // maplibregl.setWorkerUrl() call). The worker's own bundle does a
+ // relative ESM import of its "shared" chunk, so both files must be
+ // copied verbatim, unhashed, into the same output directory.
+ {
+ from: 'node_modules/maplibre-gl/dist/maplibre-gl-worker.mjs',
+ to: 'maplibre-gl-worker.mjs',
Review Comment:
Thanks Joe, this is a correct review. I've fixed in
3c7d4550bcb46a0ed071baa253262801c9cb026e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
