bito-code-review[bot] commented on code in PR #44964: URL: https://github.com/apache/superset/pull/44964#discussion_r4178712780
########## superset-frontend/.storybook/setup-stories.test.ts: ########## @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +import { expect, test } from '@playwright/test'; +import type { StoryPage } from './setup-stories'; +import { visitStory } from './setup-stories'; + +type Listener = (payload: never) => void; + +interface StoryFixture { + play?: () => Promise<void>; + throwPlayFunctionExceptions?: boolean; +} + +function createPage({ + play, + throwPlayFunctionExceptions = false, +}: StoryFixture = {}): StoryPage { + const listeners = new Map<string, Listener>(); + const channel = { + on: (event: string, listener: Listener) => listeners.set(event, listener), + emit: (event: string, payload: unknown) => + listeners.get(event)?.(payload as never), + }; + + return { + addInitScript: async script => script(), + goto: async () => { + Reflect.set(globalThis, '__STORYBOOK_ADDONS_CHANNEL__', channel); + let status = 'success'; + try { + await play?.(); + } catch (error) { + channel.emit('playFunctionThrewException', error); + if (throwPlayFunctionExceptions) { + status = 'error'; + } Review Comment: <!-- Bito Reply --> The suggestion provided by the reviewer is appropriate. It identifies a branch in the `createPage` function that is currently unreachable because the `throwPlayFunctionExceptions` flag is always `false` in the existing test setup. Adding a test case that sets this flag to `true` and asserts the expected error behavior would improve test coverage and ensure the error-handling logic remains functional. **superset-frontend/.storybook/setup-stories.test.ts** ``` goto: async () => { Reflect.set(globalThis, '__STORYBOOK_ADDONS_CHANNEL__', channel); let status = 'success'; try { await play?.(); } catch (error) { channel.emit('playFunctionThrewException', error); if (throwPlayFunctionExceptions) { status = 'error'; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
