bito-code-review[bot] commented on code in PR #43176:
URL: https://github.com/apache/superset/pull/43176#discussion_r4178982832
##########
tests/unit_tests/mcp_service/chart/tool/test_get_chart_sql.py:
##########
@@ -228,6 +231,133 @@ def test_null_chart_metadata(self):
assert output.datasource_name is None
+class TestChartSqlJinjaContext:
+ """SQL generation must expose the same Jinja inputs as chart data
execution."""
+
+ def _command_observing_jinja(self, observed: dict[str, bool]) -> type:
Review Comment:
<!-- Bito Reply -->
The suggestion to add docstrings to the test helper functions is
appropriate. Adding these docstrings improves code maintainability and adheres
to the project's documentation standards for new test functions.
**tests/unit_tests/mcp_service/chart/tool/test_get_chart_sql.py**
```
def _command_observing_jinja(self, observed: dict[str, bool]) -> type:
"""Build a ChartDataCommand double that asserts request-dependent
Jinja inputs during run()."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
