codeant-ai-for-open-source[bot] commented on code in PR #44968:
URL: https://github.com/apache/superset/pull/44968#discussion_r4179509149
##########
superset/commands/sql_lab/estimate.py:
##########
@@ -91,7 +92,7 @@ def validate(self) -> None:
catalog=self._catalog,
schema=self._schema or None,
template_params=self._template_params,
- force_dataset_match=True,
+ force_dataset_match=requires_dataset_match(),
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `834f4d3`.
The estimation path authorizes the source before rendering, then authorizes
the literal SQL rendered by `run()` without rendering it again, so access is
checked against the SQL being estimated.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
