L4XB commented on PR #44347:
URL: https://github.com/apache/superset/pull/44347#issuecomment-5993031803
Merged master to resolve the conflict in `superset/commands/chart/export.py`
with #44396 and #43232. No behavior change beyond what was approved:
- `_file_content`: the semantic-view branch from #44396 comes first, and a
dataset-backed chart now goes through `find_chart_dataset` in its `elif`.
- `_export`: the dataset export keeps `include_deleted=True`, followed by
the annotation-layer export from #43232. Annotation-source charts are exported
through `_export` too, so they get the same dataset lookup.
Checked on the merged tree:
- `tests/unit_tests/commands/chart/export_test.py`: 6 passed.
-
`tests/unit_tests/{commands,charts,datasets,dashboards,annotation_layers}`:
2382 passed. The one failure, `sql_lab/test_estimate.py`, is a missing
`psycopg2` in my local env.
- `ruff format --check` and `ruff check` (0.9.7) and `mypy
--check-untyped-defs` (1.15.0, the pre-commit hook's stubs) are clean on the
three files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
